bytes: clean up a test #29996
bytes: clean up a test #29996
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: 8d74c66) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/160420 to see it. Tip: You can toggle comments from me using the |
|
no |
|
Message from Keith Randall: Patch Set 1: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=d7d7d2cb Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
Message from Brad Fitzpatrick: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
Message from Leon Klingele: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
This PR (HEAD: 8c23883) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/160420 to see it. Tip: You can toggle comments from me using the |
|
Message from Brad Fitzpatrick: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
leonklingele
force-pushed
the
bytes-remove-inefficient-assignment
branch
from
8c23883 to
c9b13ec
Compare
|
This PR (HEAD: c9b13ec) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/160420 to see it. Tip: You can toggle comments from me using the |
leonklingele
changed the title
|
Message from Leon Klingele: Patch Set 2: (4 comments) Updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
Message from Brad Fitzpatrick: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=54e5a061 Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
Message from Leon Klingele: Patch Set 4: btw, why are tests not executed right before merge? Otherwise there might be a data race where new code just got merged in which gets broken by this change? Gobot only did a test of this change with outdated code. Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
Message from Leon Klingele: Patch Set 4:
Oh, and I'm not talking about merge conflicts, but rather behavior conflicts. Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
|
Message from Brad Fitzpatrick: Patch Set 4:
Please don’t reply on this GitHub thread. Visit golang.org/cl/160420. |
Change-Id: Iaa0e1721996b582bba9509c083755e1f125abb6b GitHub-Last-Rev: c9b13ec GitHub-Pull-Request: #29996 Reviewed-on: https://go-review.googlesource.com/c/160420 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Keith Randall <[email protected]>
|
This PR is being closed because golang.org/cl/160420 has been merged. |
No description provided.